deprecation fix: use new SCSS syntax #2088
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 8, 2016
Fixes deprecation warning with SASS and Compass#2052 ``` DEPRECATION WARNING on line 92 of /Users/mattheworiordan/.rvm/gems/ruby-2.2.2/gems/compass-core-1.0.3/stylesheets/compass/css3/_deprecated-support.scss: #{} interpolation near operators will be simplified in a future version of Sass. To preserve the current behavior, use quotes: unquote('"$ie6-"#{$legacy-support-for-ie6} "$ie7-"#{$legacy-support-for-ie7} "$ie8-"#{$legacy-support-for-ie8}') ```
mattheworiordan
force-pushed
the
sass-deprecation-warning-fix
branch
from
b58e1ee
to
3861c9d
Compare
|
Hi @scottdavis, Thanks for maintenance. |
MutahirKazmi
approved these changes
Feb 27, 2017
|
Why isn't this merged yet? |
julkue
approved these changes
Mar 1, 2017
|
@julmot because opensource :) |
aCandidMind
referenced
this pull request
May 24, 2017
Updated README to inform users Compass is no longer supported.
|
Just as a note: PR #2094 is a clear indication that compass is no longer supported. I tried to point people in other directions with PR #2124 (e.g. using thoughtbot/bourbon). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the deprecation warning with SASS and fixes issue #2052.
Note, until this PR is merged in, if it ever will be (there are currently 45 open PRs), you can use it simply in your Rails projects by adding the following to your Gemfile:
The warning this PR fixes is: