Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module sigs.k8s.io/controller-runtime to v0.16.2 #376

Merged

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Aug 5, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
sigs.k8s.io/controller-runtime require minor v0.15.0 -> v0.16.2

⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.


Release Notes

kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime)

v0.16.2

Compare Source

What's Changed

Full Changelog: kubernetes-sigs/controller-runtime@v0.16.1...v0.16.2

v0.16.1

Compare Source

What's Changed

Full Changelog: kubernetes-sigs/controller-runtime@v0.16.0...v0.16.1

v0.16.0

Compare Source

Highlights

Changes since v0.15

⚠️ Breaking Changes
✨ New Features
🐛 Bug Fixes
🌱 Others
📖 Documentation and proposals
📈 Dependencies

Thanks to all our contributors! 😊

Full Changelog: kubernetes-sigs/controller-runtime@v0.15.0...v0.16.0

v0.15.2

Compare Source

What's Changed

Full Changelog: kubernetes-sigs/controller-runtime@v0.15.1...v0.15.2

v0.15.1

Compare Source

What's Changed

Full Changelog: kubernetes-sigs/controller-runtime@v0.15.0...v0.15.1


Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@openshift-ci
Copy link

openshift-ci bot commented Aug 5, 2023

Hi @renovate[bot]. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhmdnd
Copy link

rhmdnd commented Aug 7, 2023

/test e2e-aws-serial

Test timed out waiting for the content to become available, but it appears to have been parsed correctly..

Copy link

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@renovate renovate bot force-pushed the renovate/sigs.k8s.io-controller-runtime-0.x branch from 42f7c15 to 62dda46 Compare August 7, 2023 16:55
@openshift-ci openshift-ci bot removed the lgtm label Aug 7, 2023
@rhmdnd
Copy link

rhmdnd commented Aug 14, 2023

/test e2e-aws-serial

@rhmdnd
Copy link

rhmdnd commented Aug 15, 2023

/test e2e-aws-serial

Failed to get infrastructure from AWS.

@renovate renovate bot force-pushed the renovate/sigs.k8s.io-controller-runtime-0.x branch from 62dda46 to 3f4836e Compare August 17, 2023 19:00
@renovate renovate bot changed the title fix(deps): update module sigs.k8s.io/controller-runtime to v0.15.1 fix(deps): update module sigs.k8s.io/controller-runtime to v0.16.0 Aug 22, 2023
@renovate renovate bot force-pushed the renovate/sigs.k8s.io-controller-runtime-0.x branch from 3f4836e to 79f9a3b Compare August 22, 2023 17:04
@renovate renovate bot changed the title fix(deps): update module sigs.k8s.io/controller-runtime to v0.16.0 fix(deps): update module sigs.k8s.io/controller-runtime to v0.16.1 Aug 31, 2023
@renovate renovate bot force-pushed the renovate/sigs.k8s.io-controller-runtime-0.x branch from 79f9a3b to 4909538 Compare August 31, 2023 20:22
@renovate renovate bot force-pushed the renovate/sigs.k8s.io-controller-runtime-0.x branch from 4909538 to aa351cc Compare September 12, 2023 13:19
@renovate renovate bot changed the title fix(deps): update module sigs.k8s.io/controller-runtime to v0.16.1 fix(deps): update module sigs.k8s.io/controller-runtime to v0.16.2 Sep 12, 2023
@renovate renovate bot force-pushed the renovate/sigs.k8s.io-controller-runtime-0.x branch 2 times, most recently from 1ee44ae to 4520ab2 Compare September 15, 2023 20:03
@rhmdnd
Copy link

rhmdnd commented Sep 16, 2023

/retest

@rhmdnd rhmdnd force-pushed the renovate/sigs.k8s.io-controller-runtime-0.x branch from 4520ab2 to cfbb985 Compare September 17, 2023 02:25
@rhmdnd
Copy link

rhmdnd commented Sep 17, 2023

Had to massage some of the code to get this dependency to build locally given some breaking changes between 0.15.0 and 0.16.3.

@rhmdnd rhmdnd requested review from yuumasato and removed request for mrogers950 September 17, 2023 02:27
@rhmdnd rhmdnd requested a review from Vincent056 September 17, 2023 02:27
@rhmdnd rhmdnd force-pushed the renovate/sigs.k8s.io-controller-runtime-0.x branch 4 times, most recently from c107377 to 206fe25 Compare September 19, 2023 17:28
@renovate renovate bot force-pushed the renovate/sigs.k8s.io-controller-runtime-0.x branch from 206fe25 to fbf781f Compare September 19, 2023 17:29
@renovate
Copy link
Author

renovate bot commented Sep 19, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@rhmdnd
Copy link

rhmdnd commented Sep 19, 2023

/test e2e-aws-serial

@rhmdnd
Copy link

rhmdnd commented Sep 20, 2023

Seems like there is a legitimate issue in the e2e tests because they're both waiting for the profile bundle to become Valid.

@rhmdnd
Copy link

rhmdnd commented Sep 20, 2023

Aha - yep, wiring up the metrics endpoint incorrectly:

{"level":"error","ts":"2023-09-19T20:43:13.653Z","logger":"setup","msg":"Manager exited non-zero","error":"[failed to start metrics server: failed to create listener: listen tcp: address 0.0.0.0: missing port in address, failed waiting for all runnables to end within grace period of 30s: context deadline exceeded]","errorCauses":[{"error":"failed to start metrics server: failed to create listener: listen tcp: address 0.0.0.0: missing port in address"},{"error":"failed waiting for all runnables to end within grace period of 30s: context deadline exceeded"}],"stacktrace":"github.com/ComplianceAsCode/compliance-operator/cmd/manager.RunOperator\n\tgithub.com/ComplianceAsCode/compliance-operator/cmd/manager/operator.go:329\ngithub.com/spf13/cobra.(*Command).execute\n\tgithub.com/spf13/cobra@v1.7.0/command.go:944\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\tgithub.com/spf13/cobra@v1.7.0/command.go:1068\ngithub.com/spf13/cobra.(*Command).Execute\n\tgithub.com/spf13/cobra@v1.7.0/command.go:992\nmain.main\n\tgithub.com/openshift/compliance-operator/main.go:46\nruntime.main\n\truntime/proc.go:250"}

@rhmdnd rhmdnd force-pushed the renovate/sigs.k8s.io-controller-runtime-0.x branch from 150f5a6 to 3f11eb4 Compare September 20, 2023 14:56
For some reason we're seeing issues with how the fake client behaves
with 0.16.2 but not 0.16.1.

Let's downgrade to 0.16.1 until we nail down what's going on with
0.16.2.
@rhmdnd rhmdnd force-pushed the renovate/sigs.k8s.io-controller-runtime-0.x branch from 3f11eb4 to 41d8dfc Compare September 20, 2023 14:57
@rhmdnd
Copy link

rhmdnd commented Sep 20, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 20, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: renovate[bot], rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 560273b into master Sep 20, 2023
@openshift-merge-robot openshift-merge-robot deleted the renovate/sigs.k8s.io-controller-runtime-0.x branch September 20, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants