Document namespace prefix when scanning a hosted cluster #382
Conversation
yuumasato
force-pushed
the
document_hypershift_hosted_cluster_namespace
branch
from
340f19a to
90fbb12
Compare
yuumasato
force-pushed
the
document_hypershift_hosted_cluster_namespace
branch
2 times, most recently
from
19275e2 to
71baf7e
Compare
|
I have fixed a small typo and rephrased one sentence. |
|
@yuumasato: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
yuumasato
force-pushed
the
document_hypershift_hosted_cluster_namespace
branch
from
71baf7e to
3638385
Compare
doc/usage.md
Outdated
| you can either extend `ocp4-cis` or `ocp4-pci-dss`. | ||
|
|
||
| In order to scan a Hosted Cluster, you need to create a TailoredProfile specifying the | ||
| name and namespace of the Hosted cluster that you want to scan. |
There was a problem hiding this comment.
nit: Hosted Cluster (to be consistent with the line above).
doc/usage.md
Outdated
| for the Hosted Cluster with a tailoredProfile. | ||
| [Hypershift](https://hypershift-docs.netlify.app/) allows one to create and manage clusters on existing infrastructure. | ||
| Compliance Operator is able to create a platform scan on the [HyperShift Management Cluster](https://hypershift-docs.netlify.app/reference/concepts-and-personas/) | ||
| for the Hosted Cluster with a TailoredProfile. |
There was a problem hiding this comment.
Similar to my comments on another review. What are our thoughts on using literals for formal CRD names?
There was a problem hiding this comment.
Should be fixed as well.
When using hypershift and scanning a hosted cluster, the namespace of the hosted cluster needs to be defined as well. The namespace where clusters are installed can vary, and should be set accordingly for th scans to work.
Add very brief description of Hypershift and reference where Management and Hosted Clusters are described.
Also, for consistency, capitalize term Hosted Cluster.
yuumasato
force-pushed
the
document_hypershift_hosted_cluster_namespace
branch
from
3638385 to
c6e904f
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, yuumasato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/px-approved Applying necessary labels since this documenting existing behavior. Adding @sheriff-rh for downstream documentation awareness. |
When using hypershift and scanning a hosted cluster, the namespace of the hosted cluster needs to be defined as well.
The namespace where clusters are installed can vary, and should be set accordingly for th scans to work.