Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red Hat Konflux update compliance-operator #630

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

red-hat-konflux[bot]
Copy link

Pipelines as Code configuration proposal

To start the PipelineRun, add a new comment with content /ok-to-test

For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun

To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Copy link

openshift-ci bot commented Nov 27, 2024

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rhmdnd rhmdnd requested review from Vincent056 and rhmdnd and removed request for mrogers950 and BhargaviGudi November 27, 2024 20:34
Copy link

@Vincent056 Vincent056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:630-dba80295c6a84b966c9637a243981215d70574b7

Signed-off-by: red-hat-konflux <konflux@no-reply.konflux-ci.dev>
@rhmdnd rhmdnd force-pushed the appstudio-compliance-operator branch from dba8029 to ee089ba Compare November 27, 2024 20:55
@openshift-ci openshift-ci bot removed the lgtm label Nov 27, 2024
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:630-ee089ba033f23c0c8586ca04eff32c7c785d63c0

This change updates the Dockerfile for Konflux in a few ways:

- Use a minimal UBI image for the operator to reduce overall dependencies
- Remove subscription manager since Konflux has this in place already
  and we don't need to specify it directly
- Set an appropriate WORKDIR when building images so copies work
  correctly from the builder image
- Set a default USER_UID in the user_setup script
- Fix output path in copy commands to point to the correct operator
  binary
- Add some vertical spacing in Dockerfile to better readability
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:630-1cb1e982bb40aae9826f78068e41a35f688ff7ec

@rhmdnd rhmdnd added this to the 1.7.0 milestone Dec 10, 2024
@rhmdnd
Copy link

rhmdnd commented Dec 10, 2024

/ok-to-test

Copy link

openshift-ci bot commented Dec 10, 2024

@red-hat-konflux[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-rosa 1cb1e98 link true /test e2e-rosa

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: red-hat-konflux[bot], Vincent056, yuumasato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Vincent056,yuumasato]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhmdnd
Copy link

rhmdnd commented Dec 10, 2024

ROSA e2e tests are failing for an unrelated reason.

@rhmdnd rhmdnd merged commit 078832c into master Dec 10, 2024
16 of 18 checks passed
@rhmdnd rhmdnd deleted the appstudio-compliance-operator branch December 10, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants