Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding OCP4 multi-arch support #12073

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

Vincent056
Copy link
Contributor

@Vincent056 Vincent056 commented Jun 18, 2024

Let's skip sbom, before we have metal-toolbox/container-push#77 landed. Modified Dockerfile so we only build certain profiles for s390x and ppc64le. Update github action to build for s390x and ppc64le.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Vincent056 Vincent056 requested review from rhmdnd and yuumasato June 18, 2024 09:57
Copy link

github-actions bot commented Jun 18, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12073
This image was built from commit: 2035c6a

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12073

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12073 make deploy-local

@marcusburghardt marcusburghardt added the OpenShift OpenShift product related. label Jun 18, 2024
@yuumasato
Copy link
Member

@Vincent056 How would you like to continue since metal-toolbox/container-push#77 was merged?

@Vincent056
Copy link
Contributor Author

@Vincent056 How would you like to continue since metal-toolbox/container-push#77 was merged?

@yuumasato I was just about to update it, this one should work

Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vincent056 The container file is not identical to what we use downstream, so profiles and products available will be slightly different.

For the moment, I lean towards having identical builds upstream and downstream.

Dockerfiles/ocp4_content Outdated Show resolved Hide resolved
Dockerfiles/ocp4_content Outdated Show resolved Hide resolved
Dockerfiles/ocp4_content Show resolved Hide resolved
@yuumasato yuumasato self-assigned this Jun 19, 2024
Let's skip sbom, using a forked github action for now before we have metal-toolbox/container-push#77 landed.
Modified Dockerfile so we only build certain profiles for s390x and ppc64le.
Update github action to build for s390x and ppc64le.
Copy link

codeclimate bot commented Jun 20, 2024

Code Climate has analyzed commit 2035c6a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Let's see how this runs this time.

@Vincent056 Vincent056 merged commit 71d1222 into ComplianceAsCode:master Jun 21, 2024
92 of 93 checks passed
@jan-cerny jan-cerny added this to the 0.1.74 milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenShift OpenShift product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants