-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding OCP4 multi-arch support #12073
Conversation
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
@Vincent056 How would you like to continue since metal-toolbox/container-push#77 was merged? |
@yuumasato I was just about to update it, this one should work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vincent056 The container file is not identical to what we use downstream, so profiles and products available will be slightly different.
For the moment, I lean towards having identical builds upstream and downstream.
Let's skip sbom, using a forked github action for now before we have metal-toolbox/container-push#77 landed. Modified Dockerfile so we only build certain profiles for s390x and ppc64le. Update github action to build for s390x and ppc64le.
Code Climate has analyzed commit 2035c6a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Let's see how this runs this time.
Let's skip sbom, before we have metal-toolbox/container-push#77 landed. Modified Dockerfile so we only build certain profiles for s390x and ppc64le. Update github action to build for s390x and ppc64le.