Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary String allocations #477

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

mina86
Copy link
Contributor

@mina86 mina86 commented Mar 1, 2024

No description provided.

@mina86
Copy link
Contributor Author

mina86 commented Mar 3, 2024

Not sure what the issue with CI is. The error is in clap_lex dependency which shouldn’t be relevant to this PR:

Error:    --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/clap_lex-0.7.0/src/ext.rs:186:26
    |
186 |         let bytes = self.as_encoded_bytes();
    |                          ^^^^^^^^^^^^^^^^ method not found in `&OsStr`

@dhruvja
Copy link
Collaborator

dhruvja commented Apr 23, 2024

i think the CI seems to be fixed.

@mina86 mina86 merged commit 1e387ab into ComposableFi:master Apr 23, 2024
2 checks passed
@mina86 mina86 deleted the c branch April 23, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants