-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mocks feature to solana-ibc #31
Comments
i dont think they are always enabled. For testing, we have to build by specifying
If the feature is not specified while building, the mock features are not included. |
Ah, ok, in that case it’s just a matter of cleaning up this line in Cargo.toml:
so |
alright makes sense |
mina86
pushed a commit
that referenced
this issue
Oct 18, 2023
The ibc/mocks feature is only needed when solana-ibc is built with mocks feature is selected. Don’t enable it unconditionally. Fixes: #31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently solana-ibc has mock features which are always enabled. Ideally we would guard them via a
mocks
feature which is only enabled when testing and thus production code wouldn’t include the mock features.The text was updated successfully, but these errors were encountered: