Move memory and stdx to separate crates #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdx includes functions which are not dependent on any other part of the code base and are useful in any code. As such, it doesn’t make sense to keep it inside of the sealable-trie crate. Moving it to separate crate makes it more reusable. Separating memory into its own crate should make it easier to implement pool allocators since they won’t need to link to the sealable-trie crate and thus ‘know’ the details of RawNode structure.
blasrodri
approved these changes
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stdx includes functions which are not dependent on any other part of
the code base and are useful in any code. As such, it doesn’t make
sense to keep it inside of the sealable-trie crate. Moving it to
separate crate makes it more reusable.
Separating memory into its own crate should make it easier to
implement pool allocators since they won’t need to link to the
sealable-trie crate and thus ‘know’ the details of RawNode structure.