Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockchain: change signing schema #29

Closed
wants to merge 1 commit into from
Closed

blockchain: change signing schema #29

wants to merge 1 commit into from

Conversation

mina86
Copy link
Collaborator

@mina86 mina86 commented Oct 16, 2023

Rather than signing the block, change the code so that validators sign
block_height + block_hash. The advantage of this is that checking
malicious signatures doesn’t require having the whole block. This
will reduce amount of data contract and fishermen need to store to
work.

Rather than signing the block, change the code so that validators sign
block_height + block_hash.  The advantage of this is that checking
malicious signatures doesn’t require having the whole block.  This
will reduce amount of data contract and fishermen need to store to
work.
@mina86 mina86 requested a review from dhruvja October 16, 2023 11:49
@blasrodri
Copy link
Contributor

Can you please double check this with Miguel Matos?

@mina86 mina86 marked this pull request as draft October 19, 2023 14:05
@mina86
Copy link
Collaborator Author

mina86 commented Oct 23, 2023

Let’s close it for the time being. I had some more thoughts about signing. I’ll open an Issue.

@mina86 mina86 closed this Oct 23, 2023
@mina86 mina86 deleted the mpn/b branch October 23, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants