Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix color contrast #52

Merged
merged 1 commit into from
Oct 8, 2023
Merged

fix color contrast #52

merged 1 commit into from
Oct 8, 2023

Conversation

pedro4031
Copy link
Contributor

changed two color contrasts and rounded the corners of the full logo in the footer.

changed two color contrasts and rounded the corners of the full logo in the footer.
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 0e1ba43):

https://csitba--pr52-fix-color-contrast-2xbvu1oy.web.app

(expires Wed, 04 Oct 2023 23:34:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 377f490495bfcf3a132154aae1814c17febffd36

@msambartolomeo
Copy link
Member

Sobre los colores no se si me convence del todo el clarito, aunque claramente mejora mucho el contraste, por ahi poner el mismo color del logo de computer? (#faa41a)

image
Esto no se si queda del todo bien, por ahi deberiamos buscar una forma de ponerle fondo transparente a la imagen para que no quede el cuadrado

@pedro4031
Copy link
Contributor Author

pedro4031 commented Sep 30, 2023 via email

@msambartolomeo
Copy link
Member

Lo de los colores no se que quedaria mejor, puedo preguntar por el grupo a ver que opina el resto, ya que al parecer cuando haces un pr deployea la pagina en un lugar de test

@msambartolomeo msambartolomeo merged commit 7e47f98 into develop Oct 8, 2023
2 checks passed
@msambartolomeo msambartolomeo deleted the fix_color_contrast branch October 8, 2023 14:01
@msambartolomeo msambartolomeo linked an issue Oct 10, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contraste de colores
2 participants