[Schemas] Add subject, version to metadata, remove ID #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
lovromazgon
reviewed
Jun 13, 2024
lovromazgon
reviewed
Jun 19, 2024
4 tasks
lovromazgon
reviewed
Jun 27, 2024
raulb
changed the title
lovromazgon
reviewed
Jun 28, 2024
raulb
added a commit
that referenced
this pull request
Jun 28, 2024
* [Schemas] Add subject, version to metadata, remove ID (#67) * [Schemas] Add name, version to metadata, remove ID * attach schema to record * move function * move function * key and payload schema * rename * fix * remove ID field * split methods * update type * remove unused error * add schema proto * update proto * bring key schema type back * refactor instance in favor of schema type * better naming * use subject and version on metadata * update comments * fix * update proto * fix comment --------- Co-authored-by: Raúl Barroso <ra.barroso@gmail.com> * fix message ids --------- Co-authored-by: Haris Osmanagić <haris@meroxa.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on ConduitIO/conduit#1605, we realized that our current approach of fetching a schema by ID doesn't make it possible to return the schema name and version. Since the combination of a name and version is unique, and also makes it possible to return the schema name and version, we are replacing the ID with name+version.
Quick checks: