Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(schema): add methods for proto <> schema conversions #72

Merged
merged 9 commits into from
Jul 1, 2024
Merged

feat(schema): add methods for proto <> schema conversions #72

merged 9 commits into from
Jul 1, 2024

Conversation

raulb
Copy link
Member

@raulb raulb commented Jul 1, 2024 •
edited
Loading

Description

This will be used on ConduitIO/conduit-connector-protocol#96

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@raulb raulb requested a review from a team as a code owner July 1, 2024 14:49
@raulb raulb mentioned this pull request Jul 1, 2024
Merged
4 tasks
lovromazgon
lovromazgon reviewed Jul 1, 2024
View reviewed changes
schema/proto.go Outdated Show resolved Hide resolved
lovromazgon
lovromazgon reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, seems like we need to go mod tidy to make the CI action happy.

@raulb raulb requested a review from lovromazgon July 1, 2024 16:04
@raulb raulb self-assigned this Jul 1, 2024
lovromazgon
lovromazgon reviewed Jul 1, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
schema/errors.go Outdated Show resolved Hide resolved
@raulb raulb requested a review from lovromazgon July 1, 2024 16:40
lovromazgon
lovromazgon approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@raulb raulb merged commit 3948a38 into main Jul 1, 2024
4 of 5 checks passed
@raulb raulb deleted the raul/add-missing-schema-changes branch July 1, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon approved these changes

Assignees

@raulb raulb

Labels
None yet
Projects
Conduit Main
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raulb @lovromazgon