chore: Replace fmt.Printf calls with warning logs #1305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As far as I can tell, there's only two places (outside of tests) that still are using
fmt.Printf
/fmt.Println
to print warnings to stdout, in thefrontend/schema
directory. This small PR replaces them with warning logs using thelogger
module.If the severity of the message should be different from a warning, let me know so I can change it quickly.
Type of change
How has this been tested?
I've tested this locally against a test case that triggers this message (specifically https://github.com/argumentcomputer/sphinx doing a Plonk BN254 proof verification, via an FFI wrapper at https://github.com/argumentcomputer/lurk-hs), and with this patch the messages are now logged at the proper level, as follows:
Before:
After:
How has this been benchmarked?
This change is minor and has not been benchmarked.
Checklist:
golangci-lint
does not output errors locally