Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JVM client for Linea Smart Contract V6 #189

Open
3 tasks
jpnovais opened this issue Oct 16, 2024 · 4 comments
Open
3 tasks

JVM client for Linea Smart Contract V6 #189

jpnovais opened this issue Oct 16, 2024 · 4 comments
Assignees

Comments

@jpnovais
Copy link
Collaborator

Description

Build and publish mvn jar for Linea Rollup smart contract V6. New Class shall be called LineaRollupV6

Tasks

  • Issue a mvn package of jvm-libs/linea-contracts/l1-rollup. Version shall be 6.0.0, however, it's recommended to release first with 6.0.0-rc1 until we have 100% integration test;
  • Potentially adapt release jobs to support optional package classifier "build.linea:l1-rollup-contract-client:6.0.0:rc1"

Acceptance criteria

  • Package is issued in mvn repository.
@thedarkjester
Copy link
Collaborator

thedarkjester commented Oct 28, 2024

@jpnovais given we are using the SemVer 2.0 with M.m versioning, would this not be
build.linea:l1-rollup-contract-client:6.0:rc1

@jpnovais
Copy link
Collaborator Author

What if there is a but and you want to patch?
IMO, it should be 6.0.0:rc1, the RC1 means that it's still a work in progress and it not stable.

@thedarkjester
Copy link
Collaborator

Am I correct then in saying this does not align directly with the smart contract version itself, but just the client then?

@jpnovais
Copy link
Collaborator Author

Image that you release the official V6.0 (not the RC1); then you realise that there is a bug on the JAVA web3j generated wrapper, you patch it, what should the next version of that patch be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants