Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename unicode helpers #250

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Rename unicode helpers #250

merged 2 commits into from
Jan 18, 2024

Conversation

cd1m0
Copy link
Contributor

@cd1m0 cd1m0 commented Jan 18, 2024 •
edited by blitz-1306
Loading

Small cleanup pr for unicode helpers:

  • Rename toUTF8() and fromUTF8() to bytesToString() and stingToBytes() as they were badly named.
  • Rename and optimize the strByteLen() function to strUTF8Len().
  • Add another helper strUTF16IndexToUTF8Offset().

@cd1m0 cd1m0 requested a review from blitz-1306 January 18, 2024 09:04
@cd1m0 cd1m0 merged commit a85a990 into master Jan 18, 2024
2 of 3 checks passed
@cd1m0 cd1m0 deleted the rename_unicode_helpers branch January 18, 2024 09:35
@blitz-1306 blitz-1306 mentioned this pull request Jan 18, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blitz-1306 blitz-1306 blitz-1306 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cd1m0 @blitz-1306