Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate third-party BLS library #2300

Closed
benjaminion opened this issue Jul 2, 2020 · 4 comments · Fixed by #2453
Closed

Integrate third-party BLS library #2300

benjaminion opened this issue Jul 2, 2020 · 4 comments · Fixed by #2453
Assignees
@Nashatyrev

Comments

@benjaminion
Copy link
Contributor

Current target candidate is Blst.

We ought to keep the current Milagro/JVM version as well, so recommend implementing the BLS package as interfaces.
@Nashatyrev
Copy link
Contributor

The problem with SWIG binding on Windows described here: supranational/blst#4

@Nashatyrev
Copy link
Contributor

Hit the problem with high level verify function: supranational/blst#5

@Nashatyrev
Copy link
Contributor

Relates to #2127
Would probably remove some of public classes/methods when abstracting to interfaces. However particular implementations (Milagro, Blst) may leave their classes/methods public

This was referenced Jul 17, 2020
Merged
Merged
@Nashatyrev
Copy link
Contributor

The only test which fails now is the Infinity Pubkey/Signature. Here is the opened Blst issue : supranational/blst#11

@Nashatyrev Nashatyrev mentioned this issue Jul 29, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nashatyrev Nashatyrev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Supranational BLS implementation Nashatyrev/teku
2 participants
@Nashatyrev @benjaminion