Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Deneb fork choice reference tests #7539

Closed
StefanBratanov opened this issue Sep 21, 2023 · 0 comments · Fixed by #7541
Closed

Support Deneb fork choice reference tests #7539

StefanBratanov opened this issue Sep 21, 2023 · 0 comments · Fixed by #7541
Assignees
@StefanBratanov
Labels
Epic Deneb Issues required to implement Deneb upgrade

Comments

@StefanBratanov
Copy link
Contributor

StefanBratanov commented Sep 21, 2023 •
edited
Loading

We should support the new Deneb fork choice reference tests: ethereum/consensus-specs#3463

It would require changing the ForkChoiceTestExecutor to pass a real BlobSidecarManager and handle the new steps in on_block. After implementing, remove TODO and the if condition in Eth2ReferenceTestCase
@StefanBratanov StefanBratanov added the Epic Deneb Issues required to implement Deneb upgrade label Sep 21, 2023
@StefanBratanov StefanBratanov changed the title Enable Deneb fork choice reference tests Support Deneb fork choice reference tests Sep 21, 2023
@StefanBratanov StefanBratanov mentioned this issue Sep 21, 2023
Merged
2 tasks
@StefanBratanov StefanBratanov self-assigned this Sep 21, 2023
@StefanBratanov StefanBratanov mentioned this issue Sep 22, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanBratanov StefanBratanov

Labels
Epic Deneb Issues required to implement Deneb upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Deneb fork choice reference tests StefanBratanov/teku
1 participant
@StefanBratanov