Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added executionRequestsHash to EngineNewPayloadV4 #8666

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

lucassaldanha
Copy link
Member

PR Description

  • Replaced ExecutionPayloadV4 for ExecutionPayloadV3 in EngineNewPayloadV4 (eventually ExecutionPayloadV4 will be deleted)
  • Added new parameter executionRequestHash to EngineNewPayloadV4
  • Updated ExecutionClientHandler.#engineNewPayload method with a new parameter slot. This is used to resolve the milestone later, replacing the old logic that was getting the milestone from the executionPayload
  • Updated NewPayloadRequest object with a new optional field executionRequestsHash. Later this field will be populated by the hash of the requests in the beacn block body.

This PR is a preparation for the work where we need to calculate the hash of the execution requests in the beacon block body, and pass it on engine_newPayloadV4. In this PR, I am only updating the helper objects and the client call for engine_newPayloadV4.

Fixed Issue(s)

part of #8620

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link
Contributor

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would just remove .getMilestone now from ExecutionPayload to avoid it getting misused.

@lucassaldanha
Copy link
Member Author

LGTM. I would just remove .getMilestone now from ExecutionPayload to avoid it getting misused.

Will do on the follow up PR 👍

@lucassaldanha lucassaldanha merged commit a929217 into Consensys:master Oct 2, 2024
17 checks passed
@lucassaldanha lucassaldanha deleted the electra-engine-api branch October 2, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants