Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add executionRequestHash to NewPayloadRequest as part of block validation flow #8700

Merged

Conversation

lucassaldanha
Copy link
Member

@lucassaldanha lucassaldanha commented Oct 9, 2024

PR Description

  • Add executionRequestHash to NewPayloadRequest as part of block validation flow

Fixed Issue(s)

part of #8620

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@lucassaldanha lucassaldanha enabled auto-merge (squash) October 9, 2024 22:44
Copy link
Contributor

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -117,6 +124,29 @@ public BlockProcessorElectra(
this.beaconStateMutatorsElectra = beaconStateMutators;
this.beaconStateAccessorsElectra = beaconStateAccessors;
this.schemaDefinitionsElectra = schemaDefinitions;
this.executionRequestsDataCodec =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I prefer adding this initialization in SpecLogicElectra for consistency.

@lucassaldanha lucassaldanha merged commit 0067d57 into Consensys:master Oct 10, 2024
17 checks passed
@lucassaldanha lucassaldanha deleted the add_requestHash_to_newPayload branch October 11, 2024 00:31
tbenr pushed a commit to zilm13/teku that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants