Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify resources still TODO #5

Open
15 tasks
ianmiell opened this issue Sep 1, 2020 · 3 comments
Open
15 tasks

Identify resources still TODO #5

ianmiell opened this issue Sep 1, 2020 · 3 comments
Labels
good first issue Good for newcomers

Comments

@ianmiell
Copy link
Collaborator

ianmiell commented Sep 1, 2020

  • Identify top-level resources that are still TODO
  • EndpointSlice
  • CSIDriver
  • CSINode
  • VolumeAttachment
  • PersistentVolumeClaim
  • ControllerRevision
  • ControllerRevisionList
  • CustomResourceDefinition – simplest example done: Custom resource definition #48 ; TODO: add a custom resource being used example
  • Event
  • HorizontalPodAutoscalar
  • ValidatingAdmissionWebhook
  • MutatingAdmissionWebhook
  • PodDisruptionBudget
  • PriorityClass
  • PodPreset
  • Create folders for these with a README.md in each (empty is OK for now)
@ianmiell ianmiell added the good first issue Good for newcomers label Sep 1, 2020
@amouat
Copy link
Contributor

amouat commented Sep 22, 2020

Ok, I went through everything except Cluster API stuff.

There are some things that we cover in other directories that you might want to cross link e.g. IngressClass and the various Pod/ReplicaSet/Container things.

Anyway, as best as I can tell, the following is missing:

  • EndpointSlice
  • CSIDriver, CSINode, VolumeAttachment (I can't find much resources on these, I assume they're for setting up cluster specific volume types? https://kubernetes-csi.github.io/docs/csi-driver-object.html)
  • PersistentVolumeClaim (we do have PVs, but nothing about PVCs that I saw, could add to PV dir)
  • ControllerRevision & ControllerRevisionList (not sure what this is about or if it can be created by users)
  • CustomResourceDefinition
  • Event (I think this is created internally only and should be ignored)
  • HorizontalPodAutoscalar
  • ValidatingAdmissionWebhook
  • MutatingAdmissionWebhook
  • PodDisruptionBudget
  • PriorityClass
  • PodPreset

Above you mention creating empty folders for these. I'd actually recommend against that idea, as I think it will make it trickier to see what exists and what doesn't.

If it's ok with you, I'd like to take several of these resources and create independent issues for them, which can labelled good first issue and hacktoberfest.

@amouat
Copy link
Contributor

amouat commented Sep 23, 2020

Added #17, #18, #19, #20, #21, #22, #23.

I've left out resources I wasn't sure about (Event, CSIDriver, ControllerRevision).

And as above I've not done the ClusterAPI (only because of time).

@melihc1
Copy link
Contributor

melihc1 commented Jul 20, 2022

We need to update missing resources list and create separete issues for those resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants