Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP Cloud Functions example #105

Merged
merged 10 commits into from
Mar 9, 2022
Merged

GCP Cloud Functions example #105

merged 10 commits into from
Mar 9, 2022

Conversation

AymenSegni
Copy link
Contributor

@AymenSegni AymenSegni commented Sep 22, 2021

Link related issues:

Changes/added features:

  • Create GCP Cloud Functions and deploy a simple hello world app on it
    The following short checklist should be used to make sure your PR is of good quality, and can be merged easily:
  • follows project conventions
  • follows project principles
  • ./run.sh works correctly for all new examples
  • CI checks pass
  • mergeable to main (no conflicts)
  • resolved issues linked
  • Milestone linked (if applicable)

@AymenSegni AymenSegni marked this pull request as ready for review October 6, 2021 12:05
@Ileriayo
Copy link
Contributor

Ileriayo commented Oct 6, 2021

  • fixed an issue with incorrect source path using path.module and referenced the doc
  • also saw that we needed to add some permission in order to be able to trigger the function as an unauthenticated user on the internet to see the hello world message
    cc: @AymenSegni @frankscholten @mo-abdallaa

@Ileriayo Ileriayo merged commit 4ce368a into main Mar 9, 2022
@Ileriayo Ileriayo deleted the gcp_cloud_functions branch March 22, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cover all basic resources for GCP
3 participants