Fix #40 by bumping llvm-pretty{,-bc-parser submodules and passing -ffp-contract=off to Clang
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires some minor code changes to adapt to renamed functions in `copilot-3.17`.
Clang 14+ enable `-ffp-contract=on` by default, which cause floating-point expressions such as `a + b * c` to be optimized to fused multiply-add LLVM intrinsics (e.g., `llvm.fmuladd.*`). This is a problem for `copilot-verifier`, which critically relies on preserving the order of additions and mulitplications. Thankfully, we can override this option by explicitly passing `-ffp-contract=off` to Clang.
See the comments in the `cabal.project` for why this is necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a series of patches that, when combined, fix #40:
llvm-prettyandllvm-pretty-bc-parsersubmodules to bring in a series of PRs that allowcopilot-verifierto support up to LLVM 16.-ffp-contract=onby default, which cause floating-point expressions such asa + b * cto be optimized to fused multiply-add LLVM intrinsics (e.g.,llvm.fmuladd.*). This is a problem forcopilot-verifier, which critically relies on preserving the order of additions and mulitplications. Thankfully, we can override this option by explicitly passing-ffp-contract=offto Clang.copilot-verifiersupports up to LLVM 16 in theREADME.