Add single button for export all panels #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozetko
reviewed
Oct 2, 2020
rozetko
reviewed
Oct 2, 2020
src/module.ts
Outdated
| const exportTable = _.keyBy(exportPanels, 'datasource'); | ||
| datasources = (datasources as {name: string}[]) | ||
| .reduce((result, item) => { | ||
| if (exportTable[item.name]) { |
There was a problem hiding this comment.
Suggested change
| if (exportTable[item.name]) { | |
| if(exportTable[item.name]) { |
also, it's inside the reduce callback so I guess you'd want to move it 2 spaces righter
rozetko
reviewed
Oct 2, 2020
src/module.ts
Outdated
| datasources = await this.backendSrv.get(`/api/datasources`) ; | ||
|
|
||
| const exportTable = _.keyBy(exportPanels, 'datasource'); | ||
| datasources = (datasources as {name: string}[]) |
There was a problem hiding this comment.
is datasources object or array? because a couple of lines ago you initialize it with {}
rozetko
reviewed
Oct 2, 2020
src/partials/module.html
Outdated
| @@ -48,5 +48,13 @@ | |||
| </tr> | |||
| </tbody> | |||
| </table> | |||
| <button class="btn gf-form-btn btn-primary" | |||
| id="export-button" | |||
| ng-if="!!ctrl.panels.length" | |||
There was a problem hiding this comment.
ctrl.panels.length > 0 looks more intuitive, but maybe it's just for me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added button for export all from export panel #42
When you click the "Export all" button a task is created for each exported panel
Changes
Send many panels to the exporter, instead of one, as it was before
Small types refactoring