Support multiple panels export at once #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Title a bit obscure :0 |
jonyrock
reviewed
Oct 2, 2020
src/routes/tasks.ts
Outdated
| @@ -1,26 +1,34 @@ | |||
| import { Target } from '../target' | |||
|
|
|||
| import * as express from 'express' | |||
| import {Datasource} from "@corpglory/tsdb-kit"; | |||
There was a problem hiding this comment.
Suggested change
| import {Datasource} from "@corpglory/tsdb-kit"; | |
| import { Datasource } from "@corpglory/tsdb-kit"; |
jonyrock
reviewed
Oct 2, 2020
| let datasource = body.datasourceRequest; | ||
| let datasourceName = body.datasourceName; | ||
| let user = body.user; | ||
| const body = req.body; |
There was a problem hiding this comment.
if it was Java, I would validate each param and throw exception if necessary
jonyrock
reviewed
Oct 2, 2020
src/routes/tasks.ts
Outdated
| panelUrl: string, | ||
| datasourceRequest: Datasource, | ||
| datasourceName: string | ||
| }; | ||
|
|
||
| async function addTask(req, res) { |
There was a problem hiding this comment.
you can define a type for req, a type which has all these params you expect
jonyrock
reviewed
Oct 2, 2020
src/routes/tasks.ts
Outdated
| let target = new Target(panelUrl, user, datasource, targets, from, to, datasourceName); | ||
| target.export(); | ||
| const names = data.map(item => item.datasourceName).join(', '); | ||
| res.status(200).send('Exporting ' + names + ' data from ' + new Date(from).toLocaleString() + ' to ' + new Date(to).toLocaleString()); |
There was a problem hiding this comment.
maybe you would try something like
`Exporting ${names} data from ${new Date(from).toLocaleString()} to ${new Date(to).toLocaleString()}`
but I don't like new Date(...).toLocaleString() part
|
@sblrok but can we still export a singe metric from list? |
rozetko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added button for export all from export panel CorpGlory/grafana-data-exporter-panel#42
Changes
When creating a task, several panels are expected to be exported, instead of one, as it was before