Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/T9-update-project-dependencies #14

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Feature/T9-update-project-dependencies #14

merged 5 commits into from
Oct 23, 2023

Conversation

MarcoHuebner
Copy link
Collaborator

Adresses #9 as well as #6

  • Updated the GitHub workflow with current poetry version
  • Updated all packages to current major version - pandas should not have introduced any breaking changes, since most or even all of the processing is done in dicts and the pandas options stayed the same
  • Update poetry lock file

@pmayd
Copy link
Collaborator

pmayd commented Oct 22, 2023

Did you investigated why the cicd fails for flake8?

@MarcoHuebner
Copy link
Collaborator Author

Did you investigated why the cicd fails for flake8?

Not sure what exactly failed the plugin installations (docstrings installed but missing), but flake8 6.1.0 seemed to be the reason. After reverting to 3.9.2, it is running smoothly again

Copy link
Collaborator

@pmayd pmayd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmayd pmayd changed the base branch from main to dev October 23, 2023 19:26
@pmayd
Copy link
Collaborator

pmayd commented Oct 23, 2023

I changed the target to dev as PR are never merged into main directly

@pmayd pmayd merged commit 63ba77b into CorrelAid:dev Oct 23, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants