Feature/test coverage improval #4
Conversation
…, including built html documentation.
…in cache and cube. Hosting on ReadTheDocs has to be done by Owner/ CorrelAid (but can be requested and triggered that way).
… should be fine...
… and uninstallign poetry harder. The poetry docs should IMO suffice.
…e-commit hook and changed to hard-coded version in docs, added built documentation to artifacts, #3
…e to security issue.
|
I will try to review this PR before the next project cycle begins, totally forgot about this, sorry! |
There was a problem hiding this comment.
LGTM
I see now that you are using the new test data in the new test files so good by me! I did not test it locally but I guess we can talk more about it once we have merged it and see what is still missing. Would be nice to understand which .rst files are autogenerated and which ones have to be maintained manually, though!
This test currently serves no purpose, since there are no Sphinx documentation variables to test.
This comment was marked as outdated.
This comment was marked as outdated.
|
TODO: Double-check config tests, since they seem to mess with the |
|
That is unlikely as I tested this several times and my local config was never changed but maybe You can describe your observations. It is a little tricky to test this but the tests should use a temporary folder and config and not your local one |
|
The Is the settings still used in the when #20 is addressed? Otherwise, this could be ignored. |
We don't use a settings.ini any more, everything is directly stored in the config.ini But I just realize I might have made an error and we need it.... Once you finish your session the information is lost where to find the new config file that is stupid from my side so I actually need the settings.ini again ... Maybe we can just omit the feature that you can configure your own config dir |
Update tests for the new config and settings # 4
|
Continued from internal branch in #45 |
Pull request contains suggestion/ solution for #1 (and reintroduces the version test for compatibility with the version specified in the sphinx doc), increases test coverage to >95%, and is compatible with previous PR.
resolves #1 , resolves #24