Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Remove old ibc-v1 #1875

Merged
merged 5 commits into from
Nov 7, 2023
Merged

[2.0] Remove old ibc-v1 #1875

merged 5 commits into from
Nov 7, 2023

Conversation

chipshort
Copy link
Collaborator

closes #1434

@chipshort chipshort marked this pull request as draft September 15, 2023 14:15
@chipshort chipshort force-pushed the 1434-remove-old-ibc branch from 8263efa to 4ab25f2 Compare October 6, 2023 07:51
webmaster128
webmaster128 reviewed Oct 30, 2023
View reviewed changes
packages/std/src/ibc.rs Show resolved Hide resolved
packages/std/src/testing/mock.rs Outdated Show resolved Hide resolved
@chipshort chipshort force-pushed the 1434-remove-old-ibc branch from 4e895b4 to c80bb57 Compare November 3, 2023 10:56
@chipshort chipshort marked this pull request as ready for review November 3, 2023 10:56
@chipshort chipshort force-pushed the 1434-remove-old-ibc branch from c80bb57 to 0b903fd Compare November 6, 2023 08:09
webmaster128
webmaster128 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just CHANGELOG and MIGRATING (especially about the cargo feature removal). Then 🐎

packages/std/src/ibc.rs Show resolved Hide resolved
@chipshort chipshort force-pushed the 1434-remove-old-ibc branch from 0b903fd to 37351f1 Compare November 7, 2023 10:05
@chipshort chipshort merged commit fbf0fe7 into main Nov 7, 2023
3 checks passed
@chipshort chipshort deleted the 1434-remove-old-ibc branch November 7, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove support for IBC < v3
2 participants
@chipshort @webmaster128