Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Privatize CanonicalAddr, Binary and Size inner values #1876

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

chipshort
Copy link
Collaborator

closes #1456

@chipshort chipshort force-pushed the 1456-private-newtypes branch from 657cece to e789c71 Compare September 15, 2023 13:30
@chipshort chipshort force-pushed the 1456-private-newtypes branch from 546d2b8 to e267e59 Compare October 6, 2023 07:54
@chipshort chipshort force-pushed the 1456-private-newtypes branch from e267e59 to 463e72a Compare November 3, 2023 11:19
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a CHANGELOG an MIGRATING entry

@chipshort chipshort force-pushed the 1456-private-newtypes branch from 463e72a to 656813b Compare November 6, 2023 12:32
@webmaster128 webmaster128 merged commit 3d56455 into main Nov 6, 2023
4 of 5 checks passed
@webmaster128 webmaster128 deleted the 1456-private-newtypes branch November 6, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make all newtype inner value private
2 participants