Set the minimum ecdsa
version to v0.16.2
#1899
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cosmwasm-crypto
crate does not compile with-Zminimal-versions
option because of improper dependency toecdsa
ink256
crate. To reproduce the problem, run:The result will be:
The newest version of
ecdsa
crate is 0.16.8 but is not compatible with version 0.16.0. So specifying-Zminimal-versions
uses 0.16.0 version and our code does not compile anymore. The minimumecdsa
version needed to compilecosmwams-crypto
is 0.16.2.This change adds minimum
ecdsa
dependendency set to 0.16.2.Now the compilation is successful:
I hope that after this change, all our crates that use
cosmwasm-crypto
directly or indirectly viacosmwasm-std
will not have to fixecdsa
dependency inCargo.toml
s.