Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Use impl Into<_> for Coin constructor #1902

Merged
merged 3 commits into from
Oct 18, 2023
Merged

[2.0] Use impl Into<_> for Coin constructor #1902

merged 3 commits into from
Oct 18, 2023

Conversation

chipshort
Copy link
Collaborator

closes #1501

also did this for DecCoin

webmaster128
webmaster128 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just MIGRATING and CHANGELOG

packages/std/src/coin.rs Show resolved Hide resolved
@chipshort chipshort force-pushed the 1501-coin-constructor branch from f7e06b7 to 434ef6d Compare October 18, 2023 10:36
@chipshort chipshort merged commit febc0af into main Oct 18, 2023
3 checks passed
@chipshort chipshort deleted the 1501-coin-constructor branch October 18, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let Coin::new accept values in destination type (Uint128/String)
2 participants
@chipshort @webmaster128