Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation about conventions #57

Merged
merged 7 commits into from
Jun 21, 2024
Merged

Documentation about conventions #57

merged 7 commits into from
Jun 21, 2024

Conversation

aumetra
Copy link
Member

@aumetra aumetra commented Jun 19, 2024 •
edited
Loading

  • Library feature
  • Enum dispatch for multiple message types

@vercel Vercel
Copy link

vercel bot commented Jun 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cosmwasm-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 11:54am

@aumetra aumetra force-pushed the aw/core-conventions branch 2 times, most recently from 2c3e38b to 143ed24 Compare June 19, 2024 13:20
@aumetra aumetra marked this pull request as ready for review June 19, 2024 14:44
dakom
dakom approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@dakom dakom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple small non-blocking comments, but overall looks good :)

chipshort
chipshort approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/pages/core/conventions/library-feature.mdx Show resolved Hide resolved
This was referenced Jun 21, 2024
Closed
Closed
@aumetra aumetra merged commit 2cb191c into main Jun 21, 2024
3 checks passed
@aumetra aumetra deleted the aw/core-conventions branch June 21, 2024 12:44
@aumetra aumetra mentioned this pull request Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakom dakom dakom approved these changes

@chipshort chipshort chipshort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aumetra @chipshort @dakom