Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Sylvia 1.2.1 #7

Merged
merged 5 commits into from
Aug 23, 2024
Merged

Update to Sylvia 1.2.1 #7

merged 5 commits into from
Aug 23, 2024

Conversation

jawoznia
Copy link
Contributor

No description provided.

@jawoznia jawoznia requested a review from kulikthebird August 22, 2024 12:58
@jawoznia jawoznia changed the title Sylvia 1 2 1 Update to Sylvia 1.2.1 Aug 22, 2024
Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one thing to change - other than that it looks good - especially the generics!

src/contract.rs Show resolved Hide resolved
@jawoznia jawoznia requested a review from kulikthebird August 23, 2024 07:49
@jawoznia jawoznia force-pushed the sylvia_1_2_1 branch 2 times, most recently from ea1f90d to acc3703 Compare August 23, 2024 10:55
Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@jawoznia jawoznia merged commit c416c0c into main Aug 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants