Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix debug mLastKnownAddress path #214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🐛 Fix debug mLastKnownAddress path #214

wants to merge 1 commit into from

Conversation

valentinbreiz
Copy link
Member

No description provided.

quajak
quajak requested changes Jan 1, 2024
View reviewed changes
Copy link
Member

@quajak quajak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution works but I am not sure that we will always have Cosmos.Core be assembly 1 to be loaded, which makes this a bit brittle.

I would prefer if we fix the issue by not emitting the assembly number for AsmLabels/AsmMarkers

@valentinbreiz
Copy link
Member Author

Kind of agree but why assembly numbers was added?

@quajak
Copy link
Member

quajak commented Jan 2, 2024

Because they were added everywhere to ensure that we would not get collisions if two assemblies are called the same and have the same class. The implementation has a few unfortunate side effects since certain labels were hard-coded, like this case.

@Guillermo-Santos
Copy link

Why not replace it for something like %LastKnownAddress% and then replace it for the actual label at compile time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quajak quajak quajak requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valentinbreiz @quajak @Guillermo-Santos