-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin/vite-build #154
admin/vite-build #154
Conversation
Remove old deps Move --base config to cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only comment is that you should maybe update the README/CONTRIBUTION to make sure people know that npm run start:app
and npm run build:app
are the ways to get the app up and running. I would like Nick McGruder and other devs new to the project to have a seamless experience getting the app up and running.
Good point |
Added some documentation for new npm commands to contributing.md Added another command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beyond a question about Storybook still working everything looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Can someone give me the high level overview of what are the benefits of switching?
|
Beautiful. Thank you. |
Link to Relevant Issue
WIP #134
Description of Changes
Build the app and lib using vitejs
npm commands for the app
npm run start:app
launches the app locallynpm run build:app
builds the app in production mode. Generates static site in thebuild
dir. See an example build dir and example deployment.npm run deploy:app
deploysbuild
dir (the example app) to forked repo's gh-pagesnpm run preview:app
launches the app locally, but in production mode atlocalhost:5000/cdp-frontend
build lib
npm run build:lib
builds cdp-frontend as a library to be consumed by various CDP instances by following these recommendations. It generates adist
dir with 3 files: index.es.js, index.umd.js, and index.css (the assets are inline in the minified CSS file)misc changes
npm i
to make it work.