Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for "where" in HDF files #6

Open
afrubin opened this issue Jan 1, 2020 · 0 comments
Open

Drop support for "where" in HDF files #6

afrubin opened this issue Jan 1, 2020 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@afrubin
Copy link
Contributor

afrubin commented Jan 1, 2020

Support for SQL-like operations using the where kwarg is exposed nicely by pandas but ties us to PyTables and isn't supported by dask.

In the existing code, this is only used by a few scoring methods to get information on the wild type variant. I don't know that anyone but me really used it for post-Enrich2 analysis, so it seems like a good idea to drop this support.

The main advantage of dropping this feature is that we will be more compatible with HDF5 implementations in other languages. The indexes that PyTables adds to enable the SQL-like operations make the HDF5 files look really weird when opened in R, for example.

@afrubin afrubin added enhancement New feature or request question Further information is requested labels Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant