feat: remove visibility from the end view #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results 🚀661 tests ±0 657 ✅ +1 2m 37s ⏱️ -5s For more details on these failures, see this check. Results for commit ff1c2fb. ± Comparison against base commit 8683e36. ♻️ This comment has been updated with latest results. |
turtledreams
requested changes
Nov 11, 2024
| if (segmentation == null) { | ||
| segmentation = new HashMap<>(); | ||
| } | ||
|
|
||
| segmentation.put(VISIBILITY_KEY, state); | ||
| if (ModuleViews.VIEW_EVENT_KEY.equals(key) && !segmentation.containsKey("visit")) { |
There was a problem hiding this comment.
was it visit or dur that exclusive? or both?
There was a problem hiding this comment.
visit is exclusive for the start views
turtledreams
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.