adding checklist from annotationReports in statistics collection #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajeanneney
reviewed
Jul 29, 2024
| ); | ||
| logger.log({ | ||
| operationName: 'annotationReport', | ||
| msg: `checklist ==> ${document._id} -- ${checklists}`, |
There was a problem hiding this comment.
Il ne faut pas logger les checklist car elles peuvent contenir des données sensibles
| @@ -192,6 +201,10 @@ function buildExporter( | |||
| const anonymizer = buildAnonymizer(settingsForDocument, annotations, seed); | |||
|
|
|||
| try { | |||
| logger.log({ | |||
| operationName: 'exportDocument', | |||
| msg: `checklists ${checklists} `, | |||
There was a problem hiding this comment.
c'est fait
| @@ -100,5 +102,7 @@ async function saveStatisticsOfDocument( | |||
| }, | |||
| }); | |||
|
|
|||
| statistic = { ...annotationReportsChecklist, ...statistic }; | |||
There was a problem hiding this comment.
Cette ligne me parait être en doublon vu qu'on ajoute la checklist dans statisticsCreator.ts
Et ducoup l'objet statistic peut rester en const ligne 39 je pense
There was a problem hiding this comment.
c'est fait
| @@ -58,6 +58,7 @@ describe('buildStatistic', () => { | |||
| linkedEntitiesCount, | |||
| lastUpdateDate, | |||
| treatmentInfo, | |||
| annotationReportsChecklist: undefined, | |||
There was a problem hiding this comment.
ça pourrait être plus propre de mettre une valeur pour la checklist, ça permettrait de tester que la checklist est bien renvoyée par la fonction
En plus, vu qu'on aura d'autres évolutions sur les checklist on a intérêt a se blinder sur les test pour éviter les effets de bord lors des changements. A l'avenir il y aura peut-être un traitement de la checklist vu qu'on aura les indices dans le texte donc ça sera important d'avoir des tests selon moi
There was a problem hiding this comment.
c'est fait
* calculate axios call duration * timeout to 5 hours on nlp job * remove console log * set timetout to 10 min * finale fix * timeout on every errors on nlp job * increase pause after error --------- Co-authored-by: Antoine Jeanneney <antoine.jeanneney@justice.fr>
* add show modifications options on problem report table * simplify isDisabled condition * change order --------- Co-authored-by: Antoine Jeanneney <antoine.jeanneney@justice.fr>
* remove migrations - unused * improve readme * delete unused readme --------- Co-authored-by: Antoine Jeanneney <antoine.jeanneney@justice.fr>
* add NAO * show nac or nao in title --------- Co-authored-by: Antoine Jeanneney <antoine.jeanneney@justice.fr>
* fix scrutator authorizations * show preAssignation menu to scrutator * remove adminView when disconnect --------- Co-authored-by: Antoine Jeanneney <antoine.jeanneney@justice.fr>
* FEAT_add-docker-local-hot-reload * dockerize label with hot reload & network on sder repository * fix docker:kill * reset to give a root docker compose * complete docker.env.example * remove useless run_mode set --------- Co-authored-by: Julien Grach <julien.grach@justice.fr> Co-authored-by: Antoine Jeanneney <antoine.jeanneney@justice.fr>
* first tests and documentation of what I have try/undertand * multiline selection by clicking on line numbers * remove logs * remove buggy multiline feature * format * fine tune annotation tooltip * fix bug : selecting empty lines * hightlight selected line * fix identical line selection * auto create motivation annotation when use line selection * add popup when delete motivation annotation * disable changeCategory and link annotation for motivation * split text in annotation tooltip if too long --------- Co-authored-by: Antoine Jeanneney <antoine.jeanneney@justice.fr>
* FEAT_add-docker-local-hot-reload * fix dockerfile npm i --------- Co-authored-by: Julien Grach <julien.grach@justice.fr>
* customize entityId for motivations * clean --------- Co-authored-by: Antoine Jeanneney <antoine.jeanneney@justice.fr>
* add restartPolicy on cronjobs * deploy on dev * change branch name * change branch name * fix ci * disable branch deploy --------- Co-authored-by: Antoine Jeanneney <antoine.jeanneney@justice.fr>
* Fix/try fix import (#114) * j-7 to j-4 * add dateDecision import * set schedule to not overlap import jobs --------- Co-authored-by: Antoine Jeanneney <antoine.jeanneney@justice.fr> * choose random in old and recent documents --------- Co-authored-by: Antoine Jeanneney <antoine.jeanneney@justice.fr>
* create new annotationReport type * handle only new annotationReport * save checklist only if not empty * extract checklist rendering * add viewer mode for checklist * put chekclist in accordion * make check clickable * show lines of concerned selected check * diplay context lines for checklist * styling * add checklist header * eslint * simplify annotationReportType * fix test * change 'label' to 'category' in nlp response * update storage-example * review changes --------- Co-authored-by: Antoine Jeanneney <antoine.jeanneney@justice.fr>
Co-authored-by: Antoine Jeanneney <antoine.jeanneney@justice.fr>
ajeanneney
reviewed
Oct 31, 2024
packages/courDeCassation/src/annotator/fetcher/api/nlpApiType.ts
Outdated
Show resolved
Hide resolved
packages/courDeCassation/src/annotator/fetcher/mapper/nlpMapper.spec.ts
Outdated
Show resolved
Hide resolved
packages/courDeCassation/src/annotator/fetcher/mapper/nlpMapper.spec.ts
Outdated
Show resolved
Hide resolved
packages/courDeCassation/src/annotator/fetcher/mapper/nlpMapper.spec.ts
Outdated
Show resolved
Hide resolved
packages/courDeCassation/src/annotator/fetcher/mapper/nlpMapper.ts
Outdated
Show resolved
Hide resolved
packages/generic/backend/src/modules/statistic/service/saveStatisticsOfDocument.ts
Outdated
Show resolved
Hide resolved
packages/generic/core/src/modules/statistic/generator/statisticGenerator.ts
Outdated
Show resolved
Hide resolved
|
Je me suis permis de changer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description :
adding checklist from annotationReports collection to statistics collection for saving after in sder for data team
Describe your changes :
How to test :
annotate a document with checlist (mise en doute) and export it, go to statistics collection and see if it saved the (checkList)
Checklist before requesting a review