Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add English localization #107

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add English localization #107

wants to merge 2 commits into from

Conversation

peblair
Copy link

@peblair peblair commented May 13, 2021 •
edited
Loading

Closes #87.

Screenshots:
Screen Shot 2021-05-13 at 1 38 42 PM
Screen Shot 2021-05-13 at 1 39 36 PM

@peblair
Copy link
Author

peblair commented May 13, 2021 •
edited
Loading

My apologies; I just saw #106. I'm not sure how we want to arbitrate this. I will note that the localization required more than just updating the strings file; it was necessary to fix the locale-specific rendering of dates on the appointment page as well.

@peblair peblair force-pushed the localisation-anglais branch from a3bf290 to fe4c1d4 Compare May 13, 2021 11:39
@peblair peblair force-pushed the localisation-anglais branch from fe4c1d4 to ff1a5ff Compare May 14, 2021 23:18
@peblair peblair force-pushed the localisation-anglais branch from ff1a5ff to 43acab4 Compare May 14, 2021 23:20
@peblair
Copy link
Author

peblair commented May 14, 2021

I've updated this PR to contain the Chronodose and onboarding text items as well. Here are some screenshots:

Screen Shot 2021-05-15 at 1 02 51 AM

(☝️ I already fixed "chronodoses" to read "Chronodoses")

Screen Shot 2021-05-15 at 1 03 02 AM

(☝️ I also fixed the spacing issue in this screenshot)

Screen Shot 2021-05-15 at 1 03 16 AM

Screen Shot 2021-05-15 at 1 09 22 AM

Screen Shot 2021-05-15 at 1 13 01 AM

Screen Shot 2021-05-15 at 1 16 39 AM

I think that covers most everything, however I believe that the push notifications themselves are going to be in French, since they are coming from a remote location (or I can't find them in the repo?).

@nathanfallet nathanfallet added the outdated This pull request is outdated, and needs to be updated label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated This pull request is outdated, and needs to be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add English translations
2 participants
@peblair @nathanfallet