Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASM-4855 Make image signature validation rules customizable #14

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

mtupitsyn
Copy link
Contributor

@mtupitsyn mtupitsyn commented Sep 12, 2024

Summary and Scope

Image signature validation rules must be customizable. Customers may have their own keys (in addition to our keys) or even validation configs. Standard way of tuning deployments with customer specific parameters is using customizations.yaml file. It is used during fresh installs. During upgrades, existing configuration is preserved via k8s secret, and gets amended via update-customizations.sh script - this way we may alter configuration during future upgrades (for example, remove outdated keys).

This change also fixes misconfiguration which causes CASMTRIAGE-7287.

All PR's in this batch:

Issues and Related PRs

  • Resolves CASM-4855
  • Resolves CASMTRIAGE-7287

Testing

Tested on:

  • Virtual Shasta

Test description:

Deployed temporary build, ensured that check image policy is configured correctly.

Risks and Mitigations

Low - we change the way things configured, but resulting configuration remains the same.

@mtupitsyn mtupitsyn requested a review from a team as a code owner September 12, 2024 03:36
@mtupitsyn mtupitsyn changed the title CASM-4855 Make image validation rules customizable CASM-4855 Make image signature validation rules customizable Sep 14, 2024
@mtupitsyn mtupitsyn requested review from a team and rustydb September 14, 2024 03:32
@mtupitsyn mtupitsyn merged commit c1c18ed into main Sep 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants