Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMCMS-8707 - fix arch of image upload after customization. #2544

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

dlaine-hpe
Copy link
Contributor

Summary and Scope

The build arch env variable was not being set in all containers for the IMS jobs kicked off. That meant that it was defaulting to 'x86_64' and in the case of customizing an 'aarch64' image, when complete it was getting incorrectly uploaded and labeled as an 'x86_64' image.

This adds the 'BUILD_ARCH' env variable to the job templates for the containers that was missing that variable. This will get set to the correct value when IMS templates the job and now flows through with the correct value.

Code PR: Cray-HPE/ims#89
Manifest (main) PR: #2543

Issues and Related PRs

Testing

Tested on:

  • Mug

Test description:

I installed the new IMS helm chart on Mug, then ran jobs to insure the correct values are getting picked up and set.

  • Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)? N
  • Were continuous integration tests run? If not, why? N
  • Was upgrade tested? If not, why? Y
  • Was downgrade tested? If not, why? Y
  • Were new tests (or test issues/Jiras) created for this change? N

Risks and Mitigations

Low risk change as it is just adding missing env vars to the various containers.

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable

@dlaine-hpe dlaine-hpe requested a review from a team as a code owner July 7, 2023 20:07
@phalseth-hpe phalseth-hpe merged commit c57ddd7 into stable/1.5 Jul 7, 2023
1 check passed
@phalseth-hpe phalseth-hpe deleted the CASMCMS-8707_1.5 branch July 7, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants