CRAYSAT-1919: Update to cfs-config-util version 5.1.1 #3705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cfs-config-util image is used by the `update-mgmt-ncn-cfs-config.sh` script, which is used during patch installs. This script updates the CFS configuration assigned to management nodes so that it uses the latest version of the Ansible content from the csm-config-management repo in VCS. This new version of cfs-config-util adds support for CFS v3, and it fixes a couple bugs that resulted in data being lost from configurations that were modified with this tool (`additional_inventory` and `special_parameters`). It also better handles unknown fields in CFS configurations, so if, in the future, additional fields are added to CFS configurations, they won't be lost. Test Description: Built a CSM release distribution that contained the shell script and the latest version of the cfs-config-util image and copied it to drax. Mocked out a new CSM release and associated branch in the csm-config-management repo in VCS. Then executed the script to update the configuration currently assigned to management nodes. The script successfully updated 3 configurations assigned to those nodes and then waited for the nodes to reach a configured status.
haasken-hpe
requested review from
shivaprasad-metimath,
annapoorna-s-alt and
vinanti-p
|
/backport release/1.5 |
|
Backporting into branch release/1.5 was successful. New PR: #3706 |
annapoorna-s-alt
approved these changes
Oct 14, 2024
mtupitsyn
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
The cfs-config-util image is used by the
update-mgmt-ncn-cfs-config.shscript, which is used during patch installs. This script updates the CFS configuration assigned to management nodes so that it uses the latest version of the Ansible content from the csm-config-management repo in VCS.This new version of cfs-config-util adds support for CFS v3, and it fixes a couple bugs that resulted in data being lost from configurations that were modified with this tool (
additional_inventoryandspecial_parameters). It also better handles unknown fields in CFS configurations, so if, in the future, additional fields are added to CFS configurations, they won't be lost.Issues and Related PRs
Testing
Tested on:
Test description:
Built a CSM release distribution that contained the shell script and the latest version of the cfs-config-util image and copied it to drax. Mocked out a new CSM release and associated branch in the csm-config-management repo in VCS. Then executed the script to update the configuration currently assigned to management nodes. The script successfully updated 3 configurations assigned to those nodes and then waited for the nodes to reach a configured status.
Risks and Mitigations
This is pretty low risk, especially for CSM 1.6.0. I do not think this script currently gets used in the normal installation of CSM 1.6.0. As far as I'm aware it has only been used in the installation of CSM 1.4 and 1.5 patch versions (e.g. 1.5.2). It is good to get this fixed well before we have to release CSM 1.6.z patches though.
I will also backport to CSM 1.5 so that the fix will be in place for the next CSM 1.5 patch release, if any.
Pull Request Checklist