CASMINST-6949: create k8s auditing volumes properly #5264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bo-quan
requested review from
atifsyedali,
nrockershousen,
shunr-hpe,
GunashekarKM,
SavioJoshua,
sfkramer,
alexanderkingh,
brookshire,
kkelling-hpe and
don-bahls-hpe
|
/backport release/1.6 |
|
Backporting into branch release/1.6 was successful. New PR: #5265 |
|
/backport release/1.5 |
|
Backporting into branch release/1.5 was successful. New PR: #5266 |
kimjensen-hpe
approved these changes
Jul 30, 2024
leliasen-hpe
approved these changes
Jul 30, 2024
rustydb
requested changes
Jul 30, 2024
rustydb
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When k8s api server auditing is turned on, two volume mounts need to be added to the config. The original script didn't handle existing volume mounts which caused the k8s upgrade to fail. This PR provides the fix for the issue.
Checklist
.github/CODEOWNERSwith the corresponding team in Cray-HPE.