CASMPET-6721: istio upgrade #5271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtupitsyn
commented
Aug 1, 2024
mtupitsyn
force-pushed
the
feature/istio-upgrade
branch
from
8dfd6f1
to
6152b3b
Compare
mtupitsyn
commented
Aug 8, 2024
mtupitsyn
commented
Aug 8, 2024
mtupitsyn
commented
Aug 8, 2024
mtupitsyn
force-pushed
the
feature/istio-upgrade
branch
from
25cebb8
to
2ba9ff4
Compare
arka-pramanik-hpe
force-pushed
the
feature/istio-upgrade
branch
8 times, most recently
from
b550ec8
to
7e96c38
Compare
mtupitsyn
requested review from
haroldlongley,
jnowicki-hpe,
mharding-hpe,
nrockershousen,
shunr-hpe,
GunashekarKM,
SavioJoshua,
brookshire,
kkelling-hpe and
don-bahls-hpe
bo-quan
approved these changes
Aug 15, 2024
dborman-hpe
reviewed
Aug 15, 2024
mtupitsyn
force-pushed
the
feature/istio-upgrade
branch
from
8c0d57a
to
eb4b283
Compare
rustydb
approved these changes
Aug 20, 2024
mtupitsyn
force-pushed
the
feature/istio-upgrade
branch
from
eb4b283
to
f2c766f
Compare
Co-authored-by: Arka Pramanik <arka.pramanik@hpe.com>
If prerequisites.sh fails during/after istio upgrade, but before pods are restarted to pick up new istio-proxy image, system is left in bad shape (keycloak is down). Having TOKEN initialized lazily in this scenario allows to restart prerequisites.sh from failure point.
mtupitsyn
force-pushed
the
feature/istio-upgrade
branch
from
f2c766f
to
8541534
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrading
istioinvolves some changes in upgrade workflow. Thecray-istiochart must be upgraded before any other chart (specifically because it needs to move away from deprecated CRDs provided bycert-manager, beforecert-mangeris upgraded. Upgrade of istio compromises networking for most running services, because ofistio-proxycontainer image version mismatch withistiod. Almost all services must be restarted to re-createistio-proxysidecar containers with the right image.Checklist
.github/CODEOWNERSwith the corresponding team in Cray-HPE.