-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CASMPET-7209 add instructions to mount admin-tools bucket if desired #5314
Conversation
5a362cf
to
c3b9d7a
Compare
26bfaa0
to
5e4184d
Compare
/backport release/1.5 |
/backport release/1.4 |
Backporting into branch release/1.5 was successful. New PR: #5320 |
Backporting into branch release/1.4 was successful. New PR: #5321 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some feedback from nits to defensive programming enhancements.
Just shfmt and shellcheck need work and then we can backport to 1.5 and 1.4. |
3324173
to
9bd91eb
Compare
/backport release/1.5 |
Backporting into branch release/1.5 was successful. New PR: #5355 |
/backport release/1.4 |
Backporting into branch release/1.4 was successful. New PR: #5356 |
Co-authored-by: Russell Bunch <doomslayer@hpe.com> Signed-off-by: Lindsay Eliasen <87664908+leliasen-hpe@users.noreply.github.com>
Signed-off-by: Russell Bunch <doomslayer@hpe.com>
9bd91eb
to
f2f6fd0
Compare
Description
In CSM 1.2 and CSM 1.3, the admin-tools s3 bucket was mounted. In CSM 1.4+, this bucket is no longer mounted. This PR updates documentation so that the admin-tools bucket can be manually mounted if desired.
Tested 3 different test cases.
Admin-tools bucket was not mounted and no entry was in /etc/fstab.
Admin-tools bucket was already mounted
Admin-tools bucket was not mounted but and entry already existed in /etc/fstab
Checklist
.github/CODEOWNERS
with the corresponding team in Cray-HPE.