CASMPET-7224: remove unnecessary checking of some kubelet certs #5369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bo-quan
requested review from
haroldlongley,
jnowicki-hpe,
mharding-hpe,
nrockershousen,
shunr-hpe,
GunashekarKM,
SavioJoshua,
brookshire,
kkelling-hpe and
don-bahls-hpe
leliasen-hpe
approved these changes
Sep 12, 2024
|
/backport release/1.5 release/1.4 |
|
Backporting into branch release/1.5 was successful. New PR: #5370 |
|
Backporting into branch release/1.4 was successful. New PR: #5371 |
rustydb
approved these changes
Sep 13, 2024
|
Spellcheck is complaining about lines not touched in this PR, ignoring for now as Bo is out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When checking expiration dates of kubelet certs, not all kubelet certs need to be current. Once kubelet certificate is rotated, /var/lib/kubelet/pki/kubelet.crt is no longer used; instead the symbolic link /var/lib/kubelet/pki/kubelet-client-current.pem is used and points to the latest rotated certificate. Only cert in kubelet-client-current.pem file needs to be current. This PR fixes the doc issue.
Checklist
.github/CODEOWNERSwith the corresponding team in Cray-HPE.