fix(stacks.web): set node env only during web build step

Signed-off-by: Braden Mars <bradenmars@bradenmars.me>
CrisisCleanup · Sep 23, 2023 · 62418e8 · 62418e8
1 parent 00af0ad
commit 62418e8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/deploy-crisiscleanup-site.yml b/.github/workflows/deploy-crisiscleanup-site.yml
@@ -37,7 +37,6 @@ jobs:
       VITE_APP_SPANISH_PHONE_GATEWAY: ${{vars.VITE_APP_SPANISH_PHONE_GATEWAY}}
       VITE_APP_DEFAULT_CALLER_ID: ${{vars.VITE_APP_DEFAULT_CALLER_ID}}
       VITE_APP_CRISISCLEANUP_WEB_CLIENT_ID: ${{vars.VITE_APP_CRISISCLEANUP_WEB_CLIENT_ID}}
-      NODE_ENV: ${{vars.NODE_ENV}}
       VITE_APP_WHAT_3_WORDS_API_KEY: ${{secrets.VITE_APP_WHAT_3_WORDS_API_KEY}}
       VITE_APP_PITNEYBOWES_BASIC_AUTH_TOKEN: ${{secrets.VITE_APP_PITNEYBOWES_BASIC_AUTH_TOKEN}}
       VITE_APP_PITNEYBOWES_API_KEY: ${{secrets.VITE_APP_PITNEYBOWES_API_KEY}}
@@ -104,6 +103,8 @@ jobs:
         run: pnpm --ignore-workspace install
       - name: Build Web
         working-directory: ${{github.workspace}}/.crisiscleanup-4-web
+        env:
+          NODE_ENV: ${{vars.NODE_ENV}}
         run: pnpm --ignore-workspace build:app
       - name: Install
         run: pnpm install

diff --git a/packages/stacks/web/src/main.ts b/packages/stacks/web/src/main.ts
@@ -78,7 +78,6 @@ const pipeline = GithubCodePipeline.create({
 			'VITE_APP_SPANISH_PHONE_GATEWAY',
 			'VITE_APP_DEFAULT_CALLER_ID',
 			'VITE_APP_CRISISCLEANUP_WEB_CLIENT_ID',
-			'NODE_ENV',
 		),
 		...interpolateObject(
 			ActionsContext.SECRET,
@@ -94,6 +93,7 @@ const pipeline = GithubCodePipeline.create({
 	.synthPreStep({
 		name: 'Build Web',
 		workingDirectory: webRoot,
+		env: interpolateObject(ActionsContext.VARS, 'NODE_ENV'),
 		run: 'pnpm --ignore-workspace build:app',
 	})
 	.synthPreStep({