From cf83bade50d1bdf8921737855730309750f8f17e Mon Sep 17 00:00:00 2001 From: Braden Mars Date: Tue, 18 Jun 2024 21:01:31 -0500 Subject: [PATCH] fix(stacks.maintenance-site): explicit dependency to resolve workflow generation issue Signed-off-by: Braden Mars --- .github/workflows/deploy-au-offline-site.yml | 8 ++++---- packages/stacks/maintenance-site/src/maintenance-site.ts | 3 ++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/deploy-au-offline-site.yml b/.github/workflows/deploy-au-offline-site.yml index 35fa53d..6d415d5 100644 --- a/.github/workflows/deploy-au-offline-site.yml +++ b/.github/workflows/deploy-au-offline-site.yml @@ -147,8 +147,8 @@ jobs: targets="./cdk.out/publish-Assets-FileAsset1-step.sh,./cdk.out/publish-Assets-FileAsset2-step.sh,./cdk.out/publish-Assets-FileAsset3-step.sh,./cdk.out/publish-Assets-FileAsset4-step.sh,./cdk.out/publish-Assets-FileAsset5-step.sh,./cdk.out/publish-Assets-FileAsset6-step.sh,./cdk.out/publish-Assets-FileAsset7-step.sh,./cdk.out/publish-Assets-FileAsset8-step.sh" echo -n "$targets" | xargs -r -d',' -t -n1 -P2 /bin/bash - production-au-auofflinesiteauofflinesitezonestack-eaac685-e-deploy: - name: Deploy productionauauofflinesiteauofflinesitezonestackDB775D5A + production-au-au-offline-site-zone-stack-deploy: + name: Deploy productionauauofflinesitezonestackCFFB701E permissions: contents: read id-token: write @@ -183,7 +183,7 @@ jobs: - id: Deploy uses: aws-actions/aws-cloudformation-github-deploy@v1.2.0 with: - name: production-au-auofflinesiteauofflinesitezonestackEAAC685E + name: production-au-au-offline-site-zone-stack template: https://cdk-hnb659fds-assets-${{secrets.AWS_ACCOUNT_ID_PRODUCTION_AU}}-us-east-1.s3.us-east-1.amazonaws.com/${{ needs.publish.outputs.asset-hash1 }}.json no-fail-on-empty-changeset: "1" @@ -195,7 +195,7 @@ jobs: id-token: write needs: - Build-deploy-au-offline-site-synth - - production-au-auofflinesiteauofflinesitezonestackEAAC685E-Deploy + - production-au-au-offline-site-zone-stack-Deploy - publish runs-on: ${{inputs.runner || 'ubuntu-latest'}} steps: diff --git a/packages/stacks/maintenance-site/src/maintenance-site.ts b/packages/stacks/maintenance-site/src/maintenance-site.ts index dab804e..3bba8e5 100644 --- a/packages/stacks/maintenance-site/src/maintenance-site.ts +++ b/packages/stacks/maintenance-site/src/maintenance-site.ts @@ -45,11 +45,12 @@ export class MaintenanceSite extends Stack { // eslint-disable-next-line @typescript-eslint/no-this-alias let certStack: Stack = this if (this.region !== 'us-east-1') { - certStack = new Stack(this, id + '-zone-stack', { + certStack = new Stack(scope, id + '-zone-stack', { description: `Zone Stack for maintenance site`, crossRegionReferences: true, env: { account: this.account, region: 'us-east-1' }, }) + this.node.addDependency(certStack) } if (stackProps?.env) {