Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adjust resource requests/limits for wsgi/asgi deployments #96

Closed
wants to merge 3 commits into from
Closed

feat: adjust resource requests/limits for wsgi/asgi deployments #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4ecd6a
feat(k8s.construct.api): increase wsgi cpu requests
BradenM Sep 30, 2024
6738e5b
feat(k8s.construct.api): adjust asgi/wsgi resource requests/limits
BradenM Sep 30, 2024
ab17c6d
test: update snapshots
BradenM Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions packages/charts/crisiscleanup/test/__snapshots__/main.spec.ts.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 14 additions & 2 deletions packages/k8s/construct/api/src/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,12 @@ export class ApiWSGI
'--timeout=90',
],
...(props.probes ?? this.createHttpProbes(this.httpProbePath)),
// todo: allow config via configs schema
resources: {
cpu: this.props.containerDefaults!.resources!.cpu!,
cpu: {
request: kplus.Cpu.millis(1000),
limit: kplus.Cpu.millis(1800),
},
memory: {
request: Size.mebibytes(1200),
limit: Size.mebibytes(1200),
Expand Down Expand Up @@ -342,6 +346,14 @@ export class ApiASGI
user: 1000,
group: 1000,
},
resources: {
// todo: properly expose via configs
memory: this.props.containerDefaults!.resources!.memory!,
cpu: {
request: kplus.Cpu.millis(500),
limit: kplus.Cpu.millis(1500),
},
},
})

// rag channels stateful set
Expand Down Expand Up @@ -392,7 +404,7 @@ export class ApiASGI
},
resources: {
cpu: {
limit: kplus.Cpu.units(3),
//limit: kplus.Cpu.units(3),
request: kplus.Cpu.millis(200),
},
memory: {
Expand Down
Loading