Skip to content

Commit

Permalink
fix: retain search term on suggestion tapped on
Browse files Browse the repository at this point in the history
  • Loading branch information
Crissium committed Nov 8, 2023
1 parent 97e70aa commit ae59a8e
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ I cannot develop the iOS version because I don't have a Mac or a 99 USD/year App
## Issues

- [ ] Dynamic screen width in WebView (if you rotate from portrait to landscape, the WebView will not be resized)
- [ ] Cache the search results in local history along with the position in the page

# Development

Expand Down
4 changes: 2 additions & 2 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ android {
applicationId "com.gmail.blandilyte.silverdict"
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
versionCode 4
versionName "1.0.6"
versionCode 5
versionName "1.0.7"
}
signingConfigs {
debug {
Expand Down
4 changes: 2 additions & 2 deletions android/app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<manifest
xmlns:android="http://schemas.android.com/apk/res/android"
package="com.gmail.blandilyte.silverdict"
android:versionCode="4"
android:versionName="1.0.6">
android:versionCode="5"
android:versionName="1.0.7">

<uses-permission android:name="android.permission.INTERNET" />

Expand Down
3 changes: 1 addition & 2 deletions android/app/src/main/play/release-notes/en-US/default.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
Fix:
Tweak the colour of selects to match that of the text.
Crash when the search term contains %.
Retain the old search term when a suggestion is selected. This is the behaviour of GoldenDict.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "SilverDict",
"version": "1.0.6",
"version": "1.0.7",
"private": true,
"scripts": {
"android": "react-native run-android",
Expand Down
4 changes: 2 additions & 2 deletions src/components/QueryScreen.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,11 @@ export default function QueryScreen({ navigation }) {

try {
newQuery = decodeURIComponent(newQuery);
setQuery(newQuery);
// setQuery(newQuery);
newQuery = encodeURIComponent(newQuery);
}
catch (error) {
setQuery(newQuery);
// setQuery(newQuery);
newQuery = encodeURIComponent(newQuery);
}

Expand Down

0 comments on commit ae59a8e

Please sign in to comment.