Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill jobTitle from member enrichment #1081

Merged
merged 10 commits into from
Jul 7, 2023

Conversation

skwowet
Copy link
Member

@skwowet skwowet commented Jul 6, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 86ebcbb

Add jobTitle attribute to member object based on enrichment data. This is to enhance member profiles with external data for the premium service.

🤖 Generated by Copilot at 86ebcbb

jobTitle added
From first work experience
A spring of profiles

Why

How

🤖 Generated by Copilot at 86ebcbb

  • Add jobTitle attribute to member object based on enrichment data (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@skwowet skwowet added the Improvement Created by Linear-GitHub Sync label Jul 6, 2023
@skwowet skwowet requested a review from sausage-todd July 7, 2023 16:26
Copy link
Contributor

@sausage-todd sausage-todd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we probably should move it under the previous if that checks the length of work experiences so we don't get undefined is not a type stuff

@skwowet
Copy link
Member Author

skwowet commented Jul 7, 2023

Looks good, but we probably should move it under the previous if that checks the length of work experiences so we don't get undefined is not a type stuff

Oops, sorry for that! I just updated the PR by moving the code a little up within the condition that checks the length of work experiences.

Copy link
Contributor

@sausage-todd sausage-todd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@skwowet skwowet merged commit 1eb654f into CrowdDotDev:main Jul 7, 2023
7 checks passed
@skwowet skwowet deleted the improvement/enrichment branch July 7, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants